-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECENG-859] update circle-policy-agent version #805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document the plan to test this? I see the box checked, but are there more details than that?
@michael-webster To make sure we are not breaking anything with this change, we are relying on the unit-tests (there are enough in this repo), and they are still passing. |
Is there any way to validate the client continues to behave as expected e.g. locally building the cli and testing with that for example? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this assuming a test with a local build to confirm behavior happens.
Tested with locally built binary on Linux. |
Ticket: SECENG-859
Checklist
=========
Internal Checklist
Changes
=======
(Before) Snyk CLI result
Tested 290 dependencies for known issues, found 2 issues, 65 vulnerable paths.
(After) Snyk CLI result
Tested 290 dependencies for known issues, no vulnerable paths found.