Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix scheduler parameters to support bools and numbers #808

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andyroyle
Copy link

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

=======

  • Changed type of schedule parameters from map[string]string to map[string]interface{} to enable support for bools and numbers as well as string parameters

Rationale

=========

Without this, only strings are supported via the api-client.

Considerations

==============

map[string]interface{} will transparently marshal into json without any further changes. Changing the type of the Parameters field in the Schedule struct is, unfortunately a breaking change.

@andyroyle andyroyle force-pushed the schedule-parameter-types branch from 0f32c83 to 4f8fe1a Compare December 14, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant