Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNC-141] update circle-policy-agent to v0.0.457 - pretty-print etal #831

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

gosuku
Copy link
Contributor

@gosuku gosuku commented Jan 26, 2023

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • Updated circle-policy-agent to the latest version in go.mod. This version has changes for pretty print and others.

Rationale

=========

What was the overarching product goal of this PR as well as any pertinent
history of changes

Update to the latest version of circle-policy-agent that users can use,

Considerations

==============

Why you made some of the technical decisions that you made, especially if the
reasoning is not immediately obvious

Screenshots

============

Before

Image or [gif](https://giphy.com/apps/giphycapture)

After

Image or gif where change can be clearly seen

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from main.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

@gosuku gosuku requested a review from a team as a code owner January 26, 2023 02:07
@gosuku gosuku requested a review from davidmdm January 26, 2023 02:13
Copy link
Contributor

@sagar-connect sagar-connect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci didn't run for some reason, need to verify the builds

@gosuku gosuku requested a review from a team as a code owner January 31, 2023 18:39
@gosuku gosuku merged commit b7a08c2 into main Feb 1, 2023
@gosuku gosuku deleted the SNC-141-update-circle-policy-agent branch February 1, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants