Add --docker-socket-path flag to the local execute command #868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
=======
--docker-socket-path
flag to the execute local commandRationale
=========
When using Podman in rootless mode, the socket is located in a different path. It usually is in
/var/run/user/<user-id>/podman/podman.sock
. Because thelocal execute
has the host's docker socket hard coded to/var/run/docker.sock
, it's not possible to mount it in the Picard container if the path differs.Please note if you want to test it with podman, it will still error because further down the execution, the circleci agent in the Picard container will try and create a network name with a
/
(forward-slash) in it, which is not a valid network name for Podman. This is not a bug on this side as it works with docker, so an issue has been raised already in Podman's repository.Considerations
==============
Didn't add the environment and config file part as I wanted to know if the idea of adding such new flag is something you'd accept first before putting more work into it.
Screenshots
============
Before
Image or [gif](https://giphy.com/apps/giphycapture)After
Image or gif where change can be clearly seenHere are some helpful tips you can follow when submitting a pull request:
main
.make build
in the repository root.make test
).--debug
flag is often helpful for debugging HTTP client requests and responses.make lint
). Note: This requires Docker to run inside a local job.