Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct installation of given version with sudo #872

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

asfaltboy
Copy link
Contributor

@asfaltboy asfaltboy commented Mar 20, 2023

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

  • Update instructions for running install.sh script with sudo and environment variables

Rationale

When copy pasting the instructions, we could not install the given version. It seems bash wants the vars to be given after the sudo shell is created.

Screenshots

image

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from main.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

@asfaltboy asfaltboy requested a review from a team as a code owner March 20, 2023 13:56
Copy link
Contributor

@BeFunes BeFunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks for flagging and fixing this!!

@JulesFaucherre JulesFaucherre merged commit e0841b0 into CircleCI-Public:develop Apr 5, 2023
@asfaltboy asfaltboy deleted the patch-1 branch April 11, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants