PIPE-2315 - Removes API-Service from config compilation #878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up PR that migrates the config compilation from the unstable GraphQL service and pipes it directly to an internal service.
Checklist
Internal Checklist
Changes
Rationale
We're looking to simplify the way config compilation and validation request flow through our system.
Considerations
We'll be monitoring the rollout of this via metrics to ensure that it has the desired effect. We'll also be communicating to support teams that this is going live and to raise up any CLI related support issues immediately to the Pipeline's team.
Manual Validation
Build Command:
make build
[x] - Private orb resolution fails if owner_id not specified -
[x] - Private orb resolution fails if org is specified and no valid token -
[x] - Private orb resolution works if token specified with org -
[x] - Private orb resolution works with env variable token -
[x] - Normal config validation works as expected -
[x] - Config processing works -
[x] - Config processing works with private orb and token + org combo -
[x] - Config processing fails with token but no org