-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org-slug and org-id flags to orb validate & process commands #922
Merged
zbenhadi
merged 5 commits into
develop
from
DEVEX-856-circleci-orb-validate-fails-with-private-dependent-orb-from-same-namespace
Apr 28, 2023
Merged
Add org-slug and org-id flags to orb validate & process commands #922
zbenhadi
merged 5 commits into
develop
from
DEVEX-856-circleci-orb-validate-fails-with-private-dependent-orb-from-same-namespace
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbenhadi
force-pushed
the
DEVEX-856-circleci-orb-validate-fails-with-private-dependent-orb-from-same-namespace
branch
from
April 25, 2023 12:20
7b4e701
to
0f878f4
Compare
JulesFaucherre
suggested changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JulesFaucherre
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very great job, thanks for also fixing the slug issue on config validate!
zbenhadi
force-pushed
the
DEVEX-856-circleci-orb-validate-fails-with-private-dependent-orb-from-same-namespace
branch
from
April 27, 2023 15:09
45a0812
to
34ea5bf
Compare
KyleTryon
approved these changes
Apr 27, 2023
zbenhadi
deleted the
DEVEX-856-circleci-orb-validate-fails-with-private-dependent-orb-from-same-namespace
branch
April 28, 2023 09:01
zbenhadi
added a commit
that referenced
this pull request
May 2, 2023
* Add warning on some CLI commands that orbs cannot be deleted once they are created * Add org-slug and org-id flags to orb validate & process commands (#922) --------- Co-authored-by: rlegan <[email protected]> Co-authored-by: JulesFaucherre <[email protected]> Co-authored-by: Renaud <[email protected]>
This was referenced May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
=======
Rationale
=========
Integrate the capability to validate an orb when using other private orbs from the same namespace.