fix: use bold rather than backticks around command output #930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
color
module to bold output of update command errorRationale
Having backticks in the output of the error when update is disabled doesn't make as much since, since the backticks are rendered literally. Bolding the text probably is better visually.
Considerations
==============
I haven't figured out how to test this easily, or to force
fatih/color
to send control codes in test mode so that this can be tested.Screenshots
============
Before
After
[haven't functionally tested with the exact code, but should look roughly like this]
Here are some helpful tips you can follow when submitting a pull request:
main
.make build
in the repository root.make test
).--debug
flag is often helpful for debugging HTTP client requests and responses.make lint
). Note: This requires Docker to run inside a local job.