Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/orb init warning #938

Merged
merged 3 commits into from
May 16, 2023
Merged

Docs/orb init warning #938

merged 3 commits into from
May 16, 2023

Conversation

KyleTryon
Copy link
Contributor

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • Removed the preview messaging in the orb init command
  • When the private flag is not passed to the command, we now prompt the user to select public or private.

Rationale

=========

What was the overarching product goal of this PR as well as any pertinent
history of changes

Considerations

==============

Why you made some of the technical decisions that you made, especially if the
reasoning is not immediately obvious

Screenshots

============

Before

image

After

image

@KyleTryon KyleTryon requested review from a team as code owners May 15, 2023 14:16
Copy link
Contributor

@EricRibeiro EricRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JulesFaucherre JulesFaucherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I believe we should be doing this for orb create also, wdyt?

@JulesFaucherre JulesFaucherre merged commit fbb0d7c into develop May 16, 2023
@JulesFaucherre JulesFaucherre deleted the docs/orb-init-warning branch May 16, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants