Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename install function in the install.sh #943

Merged
merged 1 commit into from
May 16, 2023
Merged

Rename install function in the install.sh #943

merged 1 commit into from
May 16, 2023

Conversation

OdNairy
Copy link
Contributor

@OdNairy OdNairy commented May 16, 2023 •
edited
Loading

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

  • Fix the ambiguity of the install shell command and the install script function.

Rationale

As noticed in #941, the install command now gets into infinite recursion.

@OdNairy
Rename install function in the install.sh
07b63e4 
Fix the ambiguity of `install` shell command and `install` script function
@OdNairy OdNairy marked this pull request as ready for review May 16, 2023 11:24
@OdNairy OdNairy requested a review from a team as a code owner May 16, 2023 11:24
@christian-stephen christian-stephen mentioned this pull request May 16, 2023
Closed
5 tasks
@OdNairy
Copy link
Contributor Author

OdNairy commented May 16, 2023

@christian-stephen It seems that I still need approval from @CircleCI-Public/developer-experience team.

JulesFaucherre
JulesFaucherre approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@JulesFaucherre JulesFaucherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of this!

@JulesFaucherre JulesFaucherre merged commit 973b0c8 into CircleCI-Public:develop May 16, 2023
@OdNairy OdNairy deleted the patch-1 branch May 16, 2023 11:30
@JulesFaucherre JulesFaucherre mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-stephen christian-stephen christian-stephen approved these changes

@JulesFaucherre JulesFaucherre JulesFaucherre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OdNairy @JulesFaucherre @christian-stephen