Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONPREM-4] Update runner component CODEOWNERS #957

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

Stuart133
Copy link
Contributor

Checklist

=========

Internal Checklist

  • [*] I am requesting a review from my own team as well as the owning team

Changes

=======

Update CODEOWNERS with new runner team

@Stuart133 Stuart133 requested a review from a team as a code owner June 26, 2023 14:01
Copy link
Contributor

@JulesFaucherre JulesFaucherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Stuart133 , I don't know if you saw it but apparently there are some errors on the file, the message is the following:

Unknown owner on line 4: make sure the team @CircleCI-Public/on-prem exists, is publicly visible, and has write access to the repository
/api/runner @CircleCI-Public/on-prem

Same for line 5

@Stuart133
Copy link
Contributor Author

I have opened an IT ticket to get the on-prem team added with write access to this repo which should fix that error

Copy link
Contributor

@JulesFaucherre JulesFaucherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, approving it, feel free to merge it once the ticket is addressed then!

@Stuart133 Stuart133 merged commit 97a6106 into develop Jun 29, 2023
@Stuart133 Stuart133 deleted the sr/runner-owner branch June 29, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants