Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't create license file when initializing private orb #962

Conversation

loderunner
Copy link
Contributor

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

  • Don't create MIT LICENSE file when using circleci orb init --private

Rationale

Private Orbs shouldn't be loaded with a permissive license by default.

@loderunner loderunner requested review from a team as code owners July 6, 2023 16:10
@loderunner loderunner merged commit 62f7bd3 into develop Jul 10, 2023
@loderunner loderunner deleted the DEVEX-1010-issue-813-orb-init-private-should-not-create-a-licence branch July 10, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants