Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove replace directive for etcd from go.mod #966

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

loderunner
Copy link
Contributor

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

  • Remove replace directive from go.mod for github.com/coreos/etcd.

Rationale

The vulnerability this was trying to avoid has been patched in 3.4.10, 3.3.23. And anyway, it seems we don't rely on github.com/coreos/etcd anymore.

Screenshots

❯ go mod why  github.com/coreos/etcd
# github.com/coreos/etcd
(main module does not need package github.com/coreos/etcd)

@loderunner loderunner requested a review from a team as a code owner July 17, 2023 15:23
@loderunner loderunner self-assigned this Jul 17, 2023
@loderunner loderunner merged commit d63d497 into develop Jul 18, 2023
@loderunner loderunner deleted the remove-go-mod-replace-etcd branch July 18, 2023 07:45
ryan-wren pushed a commit that referenced this pull request Aug 1, 2023
* deps: remove replace directive for etcd from go.mod

* add a few miising dependencies to go.sum
JulesFaucherre pushed a commit that referenced this pull request Aug 7, 2023
* deps: remove replace directive for etcd from go.mod

* add a few miising dependencies to go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants