Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improved the compatibility matrix in the README #969

Merged
merged 1 commit into from
Jul 20, 2023
Merged

docs: Improved the compatibility matrix in the README #969

merged 1 commit into from
Jul 20, 2023

Conversation

JulesFaucherre
Copy link
Contributor

@JulesFaucherre JulesFaucherre commented Jul 19, 2023 •
edited
Loading

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

Improved the compatibility matrix of the README. Now it shows the command impacted and give a better description of what is happening as well as from which server versions the support starts from.

Rationale

After the implementation of backward compatibility, it felt necessary to improve the visibility of what was happening

Considerations

Asked a review from Server team to make sure the information here is correct

Screenshots

README URL

README screenshot:
Capture d’écran 2023-07-19 à 12 01 28

@JulesFaucherre JulesFaucherre requested a review from a team as a code owner July 19, 2023 10:02
abdelDriowya
abdelDriowya approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@abdelDriowya abdelDriowya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulesFaucherre JulesFaucherre force-pushed the task/DEVEX-1087/create-internal-doc-to-document-cli-compatibility-ap-is-usage-matrix branch from 1b6a079 to 18dc782 Compare July 19, 2023 13:48
@JulesFaucherre JulesFaucherre merged commit 72b14b4 into develop Jul 20, 2023
@JulesFaucherre JulesFaucherre deleted the task/DEVEX-1087/create-internal-doc-to-document-cli-compatibility-ap-is-usage-matrix branch July 20, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelDriowya abdelDriowya abdelDriowya approved these changes

@loderunner loderunner loderunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulesFaucherre @loderunner @abdelDriowya