Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNC-387] In policy decide, compile config only when context is config #983

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

sagar-connect
Copy link
Contributor

@sagar-connect sagar-connect commented Aug 2, 2023

Jira: SNC-387

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • In policy decide, compile config only when context is config
  • Also, remove the requirement of owner-id for compilation

Rationale

=========

The policy feature could be used non CircleCI-config related areas as well in the future.
But, the compilation is relevant to circleci configs only.

Considerations

==============

It was understood that ownerid is not needed policy compilation, so that check is also removed.

Screenshots

============

Before

Image or [gif](https://giphy.com/apps/giphycapture)

After

Image or gif where change can be clearly seen

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from main.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

… context=config.

Also, don't require owner-id for compilation
@sagar-connect sagar-connect changed the base branch from develop to main August 2, 2023 20:06
@sagar-connect sagar-connect marked this pull request as ready for review August 2, 2023 20:23
@sagar-connect sagar-connect requested a review from a team as a code owner August 2, 2023 20:23
@sagar-connect sagar-connect merged commit 5523658 into main Aug 3, 2023
@sagar-connect sagar-connect deleted the SNC-387-only-compile-config-policy branch August 3, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants