Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix snapcraft deploy #988

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix snapcraft deploy #988

merged 1 commit into from
Aug 8, 2023

Conversation

JulesFaucherre
Copy link
Contributor

@JulesFaucherre JulesFaucherre commented Aug 7, 2023

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

Changes the folder that the snapcraft part of the CI uses to get the CLI version

Rationale

With the update of goreleaser, the binaries destination folder has changed and so must be changed in the snapcraft release
To have more detail you can look into the failed workflow

Considerations

Other release flows have been looked into:

  • Chocolatey: gets the version and the binary from the GitHub release API -> is not affected
  • Homebrew: gets the version and the binary from the global download script

@JulesFaucherre JulesFaucherre requested a review from a team as a code owner August 7, 2023 15:25
Copy link
Contributor

@loderunner loderunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, this one was my fault. Thanks for taking care of it. 🙏

@JulesFaucherre JulesFaucherre merged commit 08f5061 into develop Aug 8, 2023
@JulesFaucherre JulesFaucherre deleted the fix-snap-deploy branch August 8, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants