feat: Put back telemetry #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesFaucherre
force-pushed
the
feat/DEVEX-898/add-telemetry
branch
5 times, most recently
from
387629a to
b0541fa
Compare
loderunner
approved these changes
Aug 10, 2023
This commit is a squash of many commit, if you want to retrieve the whole history, you can checkout 3c80dfe
Telemetry is disabled when:
- os.Getenv("CI") == "true" beacuse it means we are in a CI environment
and we don't want to ask for telemetry approval
- stdout is not a TTY because we can not ask for telemetry approval.
Plus it also implies we are in a script context and we may not want
to be prompt anything
JulesFaucherre
force-pushed
the
feat/DEVEX-898/add-telemetry
branch
from
b0541fa to
0b88af7
Compare
|
This is a pretty massive PR that makes it difficult to give an honest review. Is it possible to break this up into several smaller PRs to help with that? |
|
Hey @jrahme-cci , yes sorry for the massive PR, as said in the description it is a reintroduction of another PR - which is also massive... It would require a non-negligeable amount of work to split it now |
jrahme-cci
approved these changes
Sep 5, 2023
loderunner
added a commit
that referenced
this pull request
Sep 5, 2023
This reverts commit 4be7e3a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes
This PR aims at putting back the changes about telemetry that have been reverted in this PR
You can look at the original telemetry PR to see the discussions around the feature
Rationale
The PR also make sure the telemetry is never enabled in CI and script environment. In terms of code it means the telemetry will not be enabled when
os.Getenv("CI") == true(like update check) and when stdout is not a TTY.