Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve orb validation error #993

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

JulesFaucherre
Copy link
Contributor

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

Orb validation uses the v1 validation if the GraphQL detection request errors

Rationale

As stated in this issue on older versions of the GraphQL endpoint, the _schema is not requestable, this indicates an old version of the GraphQL endpoint, and should fallback to v1 validation

@JulesFaucherre JulesFaucherre requested a review from a team as a code owner August 10, 2023 09:07
@JulesFaucherre JulesFaucherre merged commit 828c70a into develop Aug 10, 2023
@JulesFaucherre JulesFaucherre deleted the fix/resolve-orb-error branch August 10, 2023 09:10
Copy link
Contributor

@loderunner loderunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, this is a temporary fix, we'll ultimately need to improve detection cases of API version clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants