Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove typo in introspection query #995

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix: Remove typo in introspection query #995

merged 1 commit into from
Aug 10, 2023

Conversation

JulesFaucherre
Copy link
Contributor

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

Introspection query was requesting _schema and not __schema

Rationale

Fixes #992

@JulesFaucherre JulesFaucherre requested review from a team as code owners August 10, 2023 09:24
loderunner
loderunner approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@loderunner loderunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have I ever mentioned my feelings about GraphQL? :trollface:

@JulesFaucherre JulesFaucherre merged commit 5f720d9 into develop Aug 10, 2023
@JulesFaucherre JulesFaucherre deleted the fix/fix-orb-validation branch August 10, 2023 09:29
@JulesFaucherre
Copy link
Contributor Author

Really sad you can't react to PR comments with 🙉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loderunner loderunner loderunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orb validation fails
2 participants
@JulesFaucherre @loderunner