properly populate the EnvironmentVariable struct #998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
=========
Internal Checklist
Changes
=======
EnvironmentVariable
struct with json tagsupdated_at
while at it, as per the API docs.Rationale
=========
Before this change, listing the environment variables in a context would result in each environment variable not being properly populated. The image below is the result of running
fmt.Errorf("%+v\n", envVariable)
, whereenvVariable
is an environmental variable extracted from aEnvironmentVariables()
call. The only thing that gets populated is the name.With the json tags, the same print produces:
Considerations
==============
It didn't work properly, now it does.
Screenshots
See screenshots above
Here are some helpful tips you can follow when submitting a pull request:
main
.make build
in the repository root.make test
).--debug
flag is often helpful for debugging HTTP client requests and responses.make lint
). Note: This requires Docker to run inside a local job.