Use the custom service account name if present, even if serviceAccoun…

…t.create is set to false
CircleCI-Public · Dec 7, 2022 · 1fe503f · 1fe503f
1 parent 52f81d6
commit 1fe503f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/Chart.yaml b/Chart.yaml
@@ -4,5 +4,5 @@ description: For deploying a CircleCI Container Agent
 icon: https://raw.githubusercontent.com/circleci/media/master/logo/build/horizontal_dark.1.png
 type: application
 
-version: "100.0.0"
+version: "100.0.1"
 appVersion: "3"
diff --git a/templates/_helpers.tpl b/templates/_helpers.tpl
@@ -54,7 +54,11 @@ app.kubernetes.io/instance: {{ .Release.Name }}
 RBAC names
 */}}
 {{- define "container-agent.serviceAccountName" -}}
+{{- if .Values.serviceAccount.create }}
 {{- default (include "container-agent.fullname" .) .Values.serviceAccount.name }}
+{{- else }}
+{{- default "default" .Values.serviceAccount.name}}
+{{- end }}
 {{- end }}
 
 {{- define "container-agent.roleName" -}}

diff --git a/templates/deployment.yaml b/templates/deployment.yaml
@@ -24,9 +24,7 @@ spec:
         - {{ toYaml . }}
       {{- end}}
     {{- end }}
-    {{- if .Values.serviceAccount.create }}
       serviceAccountName: {{ include "container-agent.serviceAccountName" . }}
-    {{- end }}
     {{- if .Values.agent.podSecurityContext }}
       securityContext: {{- toYaml .Values.agent.podSecurityContext | nindent 8 }}
     {{- end }}

diff --git a/templates/rbac.yaml b/templates/rbac.yaml
@@ -62,7 +62,7 @@ roleRef:
   kind: ClusterRole
   name: {{ include "container-agent.clusterRoleName" . }}
 {{- end }} # if .Values.agent.autodetectPlatform
-{{- end }} # if rbac.create
+{{- end }}
 {{- if .Values.logging.rbac.create }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1