Skip to content

Commit

Permalink
Fix default logging collector image tag
Browse files Browse the repository at this point in the history
Use the current major release tag instead of the rolling `edge` tag
  • Loading branch information
christian-stephen committed Jul 11, 2023
1 parent 9e6a4e7 commit a455445
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ description: For deploying a CircleCI Container Agent
icon: https://raw.githubusercontent.com/circleci/media/master/logo/build/horizontal_dark.1.png
type: application

version: "101.0.7"
version: "101.0.8"
appVersion: "3"
4 changes: 4 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

This is the Container Agent Helm Chart changelog

# 101.0.8

- Fix the default logging collector image tag

# 101.0.7

- Update README with new parameters & add some documentation links to `values.yaml`
Expand Down
30 changes: 30 additions & 0 deletions tests/deployment_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,33 @@ tests:
- equal:
path: spec.template.spec.containers[0].image
value: circleci/runner-agent:kubernetes-edge

- it: should have the default logging collector configuration
asserts:
- contains:
path: spec.template.spec.containers[0].env
content:
name: KUBE_LOGGING_IMAGE
value: "circleci/logging-collector:3"
- contains:
path: spec.template.spec.containers[0].env
content:
name: KUBE_LOGGING_SECRET
value: "logging-collector-token"
- it: should override the default logging collector configuration
set:
logging.image.registry: foo
logging.image.repository: bar
logging.image.tag: baz
logging.serviceAccount.secret.name: my-custom-secret
asserts:
- contains:
path: spec.template.spec.containers[0].env
content:
name: KUBE_LOGGING_IMAGE
value: "foo/bar:baz"
- contains:
path: spec.template.spec.containers[0].env
content:
name: KUBE_LOGGING_SECRET
value: "my-custom-secret"
2 changes: 1 addition & 1 deletion values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ logging:
image:
registry: ""
repository: "circleci/logging-collector"
tag: edge
tag: 3

# A service account with minimal permissions to collect the service container logs
serviceAccount:
Expand Down

0 comments on commit a455445

Please sign in to comment.