Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default logging collector image tag [RT-1215] #20

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fix default logging collector image tag [RT-1215] #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ description: For deploying a CircleCI Container Agent
icon: https://raw.githubusercontent.com/circleci/media/master/logo/build/horizontal_dark.1.png
type: application

version: "101.0.7"
version: "101.0.8"
appVersion: "3"
4 changes: 4 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

This is the Container Agent Helm Chart changelog

# 101.0.8

- [#20](https://github.com/CircleCI-Public/container-runner-helm-chart/pull/20) Use the current major release `3` tag instead of the rolling `edge` tag for the logging-collector image

# 101.0.7

- Update README with new parameters & add some documentation links to `values.yaml`
Expand Down
30 changes: 30 additions & 0 deletions tests/deployment_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,33 @@ tests:
- equal:
path: spec.template.spec.containers[0].image
value: circleci/runner-agent:kubernetes-edge

- it: should have the default logging collector configuration
asserts:
- contains:
path: spec.template.spec.containers[0].env
content:
name: KUBE_LOGGING_IMAGE
value: "circleci/logging-collector:3"
- contains:
path: spec.template.spec.containers[0].env
content:
name: KUBE_LOGGING_SECRET
value: "logging-collector-token"
- it: should override the default logging collector configuration
set:
logging.image.registry: foo
logging.image.repository: bar
logging.image.tag: baz
logging.serviceAccount.secret.name: my-custom-secret
asserts:
- contains:
path: spec.template.spec.containers[0].env
content:
name: KUBE_LOGGING_IMAGE
value: "foo/bar:baz"
- contains:
path: spec.template.spec.containers[0].env
content:
name: KUBE_LOGGING_SECRET
value: "my-custom-secret"
2 changes: 1 addition & 1 deletion values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ logging:
image:
registry: ""
repository: "circleci/logging-collector"
tag: edge
tag: 3

# A service account with minimal permissions to collect the service container logs
serviceAccount:
Expand Down