Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONPREM-554 | Support proxy env variables in container agent chart #29

Merged
merged 8 commits into from
Nov 7, 2023

Conversation

atulsingh0
Copy link
Contributor

⚙️ Issue
If Runner container agent is deployed behind the proxy, it is not able to communicate to the world to download agent binaries

Ticket/s: ONPREM-554

⚙️ Change

  • Added Proxy env variables in deployment
  • Added Proxy Secret if using authentrication
  • Added Test cases for the same

Change Type: Minor

AC:

Fix

Tests

  • Tests for new feature and update for changes
  • Linting passes and/or formatting matches the standard of the repo

🗒️ Documentation

  • Updated related documentation (if applicable).
  • Updated Change log (if exists)

@atulsingh0 atulsingh0 requested a review from a team as a code owner November 3, 2023 21:48
Copy link
Contributor

@christian-stephen christian-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but with the caveat we document about setting the proxy settings in the task pod. While we can pass the proxy settings in a context or project env vars, this only works for the primary container. We need to also consider the logging containers, which run as sidecars in the task pod to stream service container logs to the UI.

@atulsingh0 atulsingh0 merged commit 9b43084 into main Nov 7, 2023
1 check passed
@atulsingh0 atulsingh0 deleted the onprem-554-support-proxy branch November 7, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants