Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check pdb under agent #31

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

mattsre
Copy link
Contributor

@mattsre mattsre commented Nov 16, 2023

⚙️ Issue

Ticket/s: N/A

⚙️ Change

Change Type: bug fix

Fix

The PDB object lives under agent in values.yaml. This check mistakenly checks the root .Values rather than .Values.agent and will cause a release with .Values.agent.pdb.create: true to fail with the following error:

failed to create chart from template: template: container-agent/templates/pdb.yaml:11:14: executing "container-agent/templates/pdb.yaml" at <.Values.pdb.maxUnavailable>: nil pointer evaluating interface {}.maxUnavailable

@mattsre mattsre requested a review from a team as a code owner November 16, 2023 06:52
Copy link
Contributor

@ryanwohara ryanwohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ryanwohara ryanwohara merged commit a610e38 into CircleCI-Public:main Nov 16, 2023
ryanwohara added a commit that referenced this pull request Nov 16, 2023
* Bump version to 10.0.12
* Fix PDB by referencing the right variable
ryanwohara added a commit that referenced this pull request Nov 16, 2023
* Bump version to 10.0.12
* Fix PDB by referencing the right variable
ryanwohara added a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants