Add option to specify an existing GatewayClass #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-stephen
force-pushed
the
cs/add-option-to-specify-existing-gw
branch
4 times, most recently
from
0fc2d33 to
a3cb98b
Compare
christian-stephen
force-pushed
the
cs/add-option-to-specify-existing-gw
branch
from
a3cb98b to
0ac8cc0
Compare
christian-stephen
force-pushed
the
cs/add-option-to-specify-existing-gw
branch
from
0ac8cc0 to
ee1a6ad
Compare
Stuart133
approved these changes
Nov 27, 2023
Stuart133
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
Ticket/s: https://circleci.atlassian.net/browse/ONPREM-591
⚙️ Change
A GatewayClass is a cluster-scoped resource defined by the infrastructure provider. For permission reasons, it may make sense to externalize this. Or perhaps to share a GatewayClass among multiple container-agent instances.
Change Type:
AC:
✅ Fix
❓ Tests
🗒️ Documentation