Add option to set the GC period to tune how quickly failed Pods are removed [ONPREM-616] #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+151
to
+165
| gc: | ||
| # -- Enable garbage collection (GC) of Kubernetes objects such as Pods or Secrets left over from CircleCI tasks. | ||
| # Dangling objects may occur if container runner is forcefully deleted, causing the task state-tracking to be lost. | ||
| # GC will only remove objects labelled with `app.kubernetes.io/managed-by=circleci-container-agent`. | ||
| enabled: true | ||
|
|
||
| # -- The age of a Kubernetes object managed by container agent before GC deletes it. | ||
| # This value should be slightly longer than the `agent.maxRunTime` to prevent premature removal. | ||
| # GC may remove some objects sooner than this threshold, such as task Pod containers that fail their liveness probe. | ||
| threshold: "5h5m" | ||
|
|
||
| # -- Frequency of GC runs. Adjust this to balance minimal lingering K8s resources vs. system load. | ||
| # Infrequent runs may reduce the load but could result in excess K8s resources, while frequent runs help minimize | ||
| # resources but could increase system load. | ||
| interval: "3m" |
There was a problem hiding this comment.
I changed the settings format to match conventional values parameter scoping and also what we used elsewhere in the chart. Note that the old values are still supported in the Deployment as demonstrated by the added unit tests.
There was a problem hiding this comment.
I also updated and expanded on the descriptions.
Stuart133
approved these changes
Dec 12, 2023
…emoved Also update some of the other GC settings
christian-stephen
force-pushed
the
cs/gc-settings
branch
from
04b1e2d to
f43b190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update some of the other GC settings
⚙️ Issue
Ticket/s:
https://circleci.atlassian.net/browse/ONPREM-616
⚙️ Change
Add option to set the GC period to tune how quickly failed Pods are removed. This is now possible to set with v3.0.16.
Change Type:
AC:
✅ Fix
❓ Tests
🗒️ Documentation