Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clusterrole indentation when adding rules #39

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix clusterrole indentation when adding rules #39

merged 3 commits into from
Jan 31, 2024

Conversation

alexelent-carta
Copy link

@alexelent-carta alexelent-carta commented Jan 30, 2024 •
edited
Loading

⚙️ Issue

Ticket/s: None

⚙️ Change

Use nindent instead of indent to allow creation of new clusterRole.rules.

Change Type:

AC:

✅ Fix

❓ Tests

  • [ x ] Tests for new feature and update for changes
  • [ x ] Linting passes and/or formatting matches the standard of the repo

🗒️ Documentation

  • [ x ] Updated related documentation (if applicable).
  • [ x ] Updated Change log (if exists)

@alexelent-carta alexelent-carta requested a review from a team as a code owner January 30, 2024 21:06
@alexelent-carta
Copy link
Author

@soulchips would it be possible to get this merged as well? I do not have permission. Thanks!

Only those with write access to this repository can merge pull requests.

@soulchips soulchips merged commit 89261a4 into CircleCI-Public:main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulchips soulchips soulchips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexelent-carta @soulchips