Fixed adding additional RBAC rules.

[toran414]

⚙️ Issue

When adding additional role rules or logging role rules, the manifest it renders ends up missing a newline and always returning an error.

Error: YAML parse error on container-agent/templates/role.yaml: error converting YAML to JSON: yaml: line 15: did not find expected key helm.go:84: [debug] error converting YAML to JSON: yaml: line 15: did not find expected key

⚙️ Change

Altered the toYaml section for the extra rules to use 'nindent' instead of 'indent' to introduce a newline in order to fix the formatting.

AC:

✅ Fix

When providing additional rules, the manifest now renders as valid YAML.

❓ Tests

Ran helm template command locally and before the change it rendered and errored:

rules:
  - apiGroups: [""]
    resources: ["pods", "pods/exec", "pods/log"]
    verbs: ["get", "watch", "list", "create", "delete"]
  - apiGroups: [""]
    resources: ["secrets"]
    verbs: ["get", "list", "create", "delete"]
  - apiGroups: ["", "events.k8s.io/v1"]
    resources: ["events"]
    verbs: ["watch"] # if .Values.agent.ssh.enabled  - apiGroups:
    - ""
    resources:
    - configmaps
    verbs:
    - get
    - list
    - create
    - update
    - delete # if $role.rules

After the change it rendered and ran correctly:

 rules:
  - apiGroups: [""]
    resources: ["pods", "pods/exec", "pods/log"]
    verbs: ["get", "watch", "list", "create", "delete"]
  - apiGroups: [""]
    resources: ["secrets"]
    verbs: ["get", "list", "create", "delete"]
  - apiGroups: ["", "events.k8s.io/v1"]
    resources: ["events"]
    verbs: ["watch"] # if .Values.agent.ssh.enabled  
  - apiGroups:
    - ""
    resources:
    - configmaps
    verbs:
    - get
    - list
    - create
    - update
    - delete # if $role.rules

🗒️ Documentation

N/A -- Just a bug fix

[jrahme-cci]

I've pushed a couple additions to your changes @toran414 , mostly boiler plate stuff that should be in a contributors section of our README but isn't. Chart version updating, changelog entry, and some quick unit tests for the fix.

[jrahme-cci]

@toran414 Thanks for the contribution :D