Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONPREM-1052] Add PVC and mount to agent pod #44

Merged
merged 3 commits into from
Apr 15, 2024
Merged

[ONPREM-1052] Add PVC and mount to agent pod #44

merged 3 commits into from
Apr 15, 2024

Conversation

Stuart133
Copy link
Contributor

⚙️ Issue

Ticket/s:

⚙️ Change

Change Type:

AC:

✅ Fix

❓ Tests

  • Tests for new feature and update for changes
  • Linting passes and/or formatting matches the standard of the repo

🗒️ Documentation

  • Updated related documentation (if applicable).
  • Updated Change log (if exists)

Stuart133
Stuart133 commented Apr 11, 2024
View reviewed changes
values.yaml Outdated Show resolved Hide resolved
@Stuart133 Stuart133 marked this pull request as ready for review April 15, 2024 15:16
@Stuart133 Stuart133 requested a review from a team as a code owner April 15, 2024 15:16
christian-stephen
christian-stephen approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@christian-stephen christian-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided we add some unit tests

@Stuart133 Stuart133 merged commit d8aaf92 into main Apr 15, 2024
4 checks passed
@Stuart133 Stuart133 deleted the sr/volume-copy branch April 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-stephen christian-stephen christian-stephen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stuart133 @christian-stephen