Don’t leave rustup.sh behind or install an unused toolchain #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note: this PR was made in GitHub’s web editor and is completely untested! |
|
Hey @SimonSapin, thanks for the help! Before I look at your PR, I'll work on migrating this orb to Orb Tools 12. It should not take long. |
* This script would let rustup default to installing a `stable` toolchain, then install a different one if needed. Instead it now tells the bootstrap script which toolchain to install in the first place * Piping `curl` to `sh` avoids leaving a `rustup.sh` file behind. This could disturb some tools, for example `cargo publish` fails with: > to proceed despite this and include the uncommitted changes, pass the `--allow-dirty` flag
EricRibeiro
approved these changes
Dec 7, 2023
|
Your orb has been published to the CircleCI Orb Registry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script would let rustup default to installing a
stabletoolchain, then install a different one if needed. Instead it now tells the bootstrap script which toolchain to install in the first placePiping
curltoshavoids leaving arustup.shfile behind. This could disturb some tools, for examplecargo publishfails with: