Revert worker group IAM role policy for Nomad Autoscaler [ONPREM-553] #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-stephen
force-pushed
the
ONPREM-553/revert-node-group-policy
branch
3 times, most recently
from
e4090ed to
c3ab83b
Compare
christian-stephen
force-pushed
the
ONPREM-553/revert-node-group-policy
branch
from
c3ab83b to
6c23806
Compare
| @@ -28,7 +28,7 @@ executors: | |||
| tfsec: | |||
| resource_class: small | |||
| docker: | |||
| - image: circleci/python:latest | |||
| - image: cimg/base:current | |||
There was a problem hiding this comment.
We were using a deprecated image here introduced in PR #183. Update this to just use the base convenience image since we don't need Python.
| @@ -8,14 +8,14 @@ resource "aws_security_group" "nomad_sg" { | |||
| from_port = 64535 | |||
| to_port = 65535 | |||
| protocol = "tcp" | |||
| cidr_blocks = ["0.0.0.0/0"] | |||
| cidr_blocks = ["0.0.0.0/0"] #tfsec:ignore:aws-ec2-no-public-ingress-sgr | |||
There was a problem hiding this comment.
Temporarily ignore these failing tfsec checks introduced in PR #183 until we can properly action them as they're failing CI and making detecting other issues more difficult.
There was a problem hiding this comment.
Pretty sure we actually do want 0.0.0.0 here so we can SSH into jobs
atulsingh0
approved these changes
Nov 1, 2023
ryanwohara
approved these changes
Nov 1, 2023
christian-stephen
force-pushed
the
ONPREM-553/revert-node-group-policy
branch
from
0c102c8 to
cef746f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue https://circleci.atlassian.net/browse/ONPREM-553
✅ Fix If we upgrade Nomad Autoscaler to
v0.3.7, these changes appear to be unneeded.❓ Tests