fix: change back the job name to on-hold (#409)

.circleci/config.yml

@@ -18,6 +18,7 @@ workflows:
           filters: *filters
       - orb-tools/review:
           filters: *filters
+          exclude: RC010
       - shellcheck/check:
           shell: sh
           filters: *filters

src/examples/full_deployment_sample.yml

@@ -38,7 +38,7 @@ usage:
         # When we are on a tagged commit (example "v1.0.0"), we want to also place the workflow on-hold, pending manual approval for deployment.
         # We will also make use of the Slack orb's "on-hold" job to notify us to this on-hold workflow, making it easy to respond.
         # Add a context containing your Slack OAuth token and optionally, default slack channel
-        - slack/on_hold:
+        - slack/on-hold:
             context: slack-secrets
             requires:
               - test
@@ -51,7 +51,7 @@ usage:
             type: approval
             requires:
               - test
-              - slack/on_hold
+              - slack/on-hold
             filters:
               tags:
                 only: /^v.*/

src/examples/on_hold_notification.yml

@@ -9,7 +9,7 @@ usage:
       jobs:
         - my_test_job
         # Send a slack notfication alerting the workflow will now be placed on-hold after this notification.
-        - slack/on_hold:
+        - slack/on-hold:
             context: slack-secrets
             requires:
               - my_test_job
@@ -19,7 +19,7 @@ usage:
             type: approval
             requires:
               - my_test_job
-              - slack/on_hold
+              - slack/on-hold
         # This job will continue once the workflow has been manually approved.
         - my_deploy_job:
             requires: