Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: thread_id cache should work for all event types #449

Conversation

jasonyoung-pearl
Copy link
Contributor

Right now, if the event type is fail, the thread_id will be ignored because the save_cache and restore_cache steps do not have when set, meaning they default to on_success and do not run.

This PR changes the cache steps so that they always run (on the condition that thread_id is being set, anyway).

@jasonyoung-pearl jasonyoung-pearl changed the title fix: thread_id cache should work for all event types fix: thread_id cache should work for all event types Apr 19, 2024
@geoL86
Copy link

geoL86 commented May 14, 2024

The same behavior for me as well ... already voted

@geoL86
Copy link

geoL86 commented May 18, 2024

Hey @tremblay @aaronstillwell, guys, who has power to check and approve these changes? Look like there are not so much and will help that's for sure ...

@tremblay
Copy link

Hey @tremblay @aaronstillwell, guys, how has power to check and approve these changes? Look like there are not so much and will help that's for sure ...

not sure why you tagged me, I am not a contributor to this project in any way

Copy link

@aaronstillwell aaronstillwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should get merged in the next few days

@otremblay
Copy link

I'm the correct "tremblay" to tag on these, let me take a peek and see what I can do

@otremblay otremblay merged commit 4dc2b3e into CircleCI-Public:main May 21, 2024
2 checks passed
@orb-publisher
Copy link

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/slack?version=4.13.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants