-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACI HTTP Plugin #114
ACI HTTP Plugin #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also seem to have missed the aci_rest module changes.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 35.95% 35.60% -0.36%
==========================================
Files 179 180 +1
Lines 7995 8187 +192
Branches 1184 1214 +30
==========================================
+ Hits 2875 2915 +40
- Misses 5120 5272 +152
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@shrsr Any update on this? I'm still hoping that it get's fixed someday. 😀 |
@Schrottfresse It is still in the works but we have it in our to-do-list (near future) :) |
… original connection type
53e7136
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This ACI plugin provides the HTTP API transport methods needed to initiate
a connection to the ACI controller, send API requests and process the
response from the controller.