Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACI HTTP Plugin #114

Merged
merged 49 commits into from
Jul 26, 2023
Merged

ACI HTTP Plugin #114

merged 49 commits into from
Jul 26, 2023

Conversation

shrsr
Copy link
Collaborator

@shrsr shrsr commented Jan 8, 2021

This ACI plugin provides the HTTP API transport methods needed to initiate
a connection to the ACI controller, send API requests and process the
response from the controller.

@shrsr shrsr requested a review from lhercot January 8, 2021 16:28
@shrsr shrsr linked an issue Jan 8, 2021 that may be closed by this pull request
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also seem to have missed the aci_rest module changes.

plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/module_utils/aci.py Outdated Show resolved Hide resolved
plugins/module_utils/aci.py Outdated Show resolved Hide resolved
plugins/module_utils/aci.py Outdated Show resolved Hide resolved
plugins/module_utils/aci.py Outdated Show resolved Hide resolved
tests/integration/inventory.networking Outdated Show resolved Hide resolved
@shrsr shrsr changed the title APIC HTTP Plugin ACI HTTP Plugin Jan 14, 2021
@shrsr shrsr requested a review from lhercot January 20, 2021 05:12
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/module_utils/aci.py Outdated Show resolved Hide resolved
plugins/module_utils/aci.py Outdated Show resolved Hide resolved
plugins/modules/aci_rest.py Outdated Show resolved Hide resolved
@shrsr shrsr requested a review from lhercot January 22, 2021 17:41
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Patch coverage: 14.89% and project coverage change: -0.36% ⚠️

Comparison is base (6b54766) 35.95% compared to head (2dfb95b) 35.60%.

❗ Current head 2dfb95b differs from pull request most recent head 0bbd2b3. Consider uploading reports for the commit 0bbd2b3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   35.95%   35.60%   -0.36%     
==========================================
  Files         179      180       +1     
  Lines        7995     8187     +192     
  Branches     1184     1214      +30     
==========================================
+ Hits         2875     2915      +40     
- Misses       5120     5272     +152     
Flag Coverage Δ
sanity 35.60% <14.89%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugins/doc_fragments/aci.py 100.00% <ø> (ø)
plugins/modules/aci_access_span_src_group.py 37.20% <0.00%> (ø)
plugins/modules/aci_access_span_src_group_src.py 25.75% <0.00%> (ø)
plugins/modules/aci_config_rollback.py 33.33% <0.00%> (-2.61%) ⬇️
plugins/modules/aci_fabric_span_src_group_src.py 30.90% <0.00%> (ø)
plugins/modules/aci_rest.py 27.27% <0.00%> (-0.34%) ⬇️
plugins/modules/aci_config_snapshot.py 27.58% <10.00%> (-1.83%) ⬇️
plugins/module_utils/aci.py 11.41% <11.53%> (+0.57%) ⬆️
plugins/httpapi/aci.py 18.06% <18.06%> (ø)
plugins/module_utils/constants.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/module_utils/aci.py Outdated Show resolved Hide resolved
plugins/module_utils/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/modules/aci_config_rollback.py Outdated Show resolved Hide resolved
@shrsr shrsr self-assigned this May 18, 2021
@Schrottfresse
Copy link

@shrsr Any update on this? I'm still hoping that it get's fixed someday. 😀

@shrsr
Copy link
Collaborator Author

shrsr commented Jul 19, 2021

@Schrottfresse It is still in the works but we have it in our to-do-list (near future) :)

plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
plugins/httpapi/aci.py Outdated Show resolved Hide resolved
@shrsr shrsr requested a review from anvitha-jain July 20, 2023 21:00
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 1259294 into CiscoDevNet:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACI: Adding an ACI connection plugin for communication
6 participants