Skip to content

Commit

Permalink
Move translatable strings into a resource file
Browse files Browse the repository at this point in the history
  • Loading branch information
@Citrinate
Citrinate committed Mar 22, 2024
1 parent cc74b02 commit ccd056b
Show file tree
Hide file tree
Showing 9 changed files with 398 additions and 82 deletions.
75 changes: 38 additions & 37 deletions CS2Interface/CS/Client.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Threading;
using System.Threading.Tasks;
using ArchiSteamFarm.Steam;
using CS2Interface.Localization;
using ProtoBuf;
using SteamKit2;
using SteamKit2.GC;
Expand Down Expand Up @@ -38,17 +39,17 @@ internal async Task<bool> Run() {
}

if (ConnectionSemaphore.CurrentCount != 1) {
throw new ClientException(EClientExceptionType.Failed, "CS2 Client is already attempting to run, please wait");
throw new ClientException(EClientExceptionType.Failed, Strings.ClientAlreadyStarting);
}

if (FatalError) {
throw new ClientException(EClientExceptionType.FatalError, "CS2 Client experienced a fatal error");
throw new ClientException(EClientExceptionType.FatalError, Strings.ClientFatalError);
}

await ConnectionSemaphore.WaitAsync().ConfigureAwait(false);
try {
if (!await GameData.IsLoaded(0).ConfigureAwait(false)) {
throw new ClientException(EClientExceptionType.Failed, "Failed to load Game Data");
throw new ClientException(EClientExceptionType.Failed, Strings.GameDataLoadingFailed);
}

// TODO: Verify that this account owns CS2
Expand All @@ -69,10 +70,10 @@ internal async Task<bool> Run() {
}};
var fetcher = new GCFetcher<CMsgClientHello, CMsgClientWelcome>((uint) EGCBaseClientMsg.k_EMsgGCClientWelcome);

Bot.ArchiLogger.LogGenericDebug("Sending hello message");
Bot.ArchiLogger.LogGenericDebug(Strings.SendingHello);

if (fetcher.Fetch(this, msg, resendMsg: true) == null) {
throw new ClientException(EClientExceptionType.Timeout, "CS2 Client wasn't able to connect to GC");
throw new ClientException(EClientExceptionType.Timeout, Strings.GCConnectionFailed);
}

HasGCSession = true;
Expand Down Expand Up @@ -110,7 +111,7 @@ internal async Task<bool> VerifyConnection() {
return false;
}

Bot.ArchiLogger.LogGenericDebug("Verifying CS2 Client's connection to GC");
Bot.ArchiLogger.LogGenericDebug(Strings.VerifyingGCConnection);
try {
await RequestPlayerProfile(Bot.SteamID).ConfigureAwait(false);
} catch {
Expand All @@ -126,7 +127,7 @@ private void OnGCMessage(SteamGameCoordinator.MessageCallback callback) {
}

#if DEBUG
Bot.ArchiLogger.LogGenericDebug(String.Format("Message Received: {0}", callback.EMsg));
Bot.ArchiLogger.LogGenericDebug(String.Format("{0}: {1}", Strings.MessageRecieved, callback.EMsg));
#endif

OnGCMessageRecieved?.Invoke(callback);
Expand Down Expand Up @@ -167,7 +168,7 @@ private void OnClientWelcome(IPacketGCMsg packetMsg) {
}
}));

Bot.ArchiLogger.LogGenericDebug("CS2 inventory loaded");
Bot.ArchiLogger.LogGenericDebug(Strings.InventoryLoaded);

return;
}
Expand All @@ -177,7 +178,7 @@ private void OnClientWelcome(IPacketGCMsg packetMsg) {
private void OnFatalLogonError(IPacketGCMsg packetMsg) {
var msg = new ClientGCMsgProtobuf<CMsgGCCStrike15_v2_ClientLogonFatalError>(packetMsg);

Bot.ArchiLogger.LogGenericError(String.Format("Fatal CS2 logon error {0}: {1}", msg.Body.errorcode, msg.Body.message));
Bot.ArchiLogger.LogGenericError(String.Format("{0}: {1}", String.Format(Strings.FatalLogonError, msg.Body.errorcode), msg.Body.message));
FatalError = true;
}

Expand Down Expand Up @@ -253,7 +254,7 @@ private void OnMultiItemUpdated(IPacketGCMsg packetMsg) {

internal async Task<CMsgGCCStrike15_v2_Client2GCEconPreviewDataBlockResponse> InspectItem(ulong param_s, ulong param_a, ulong param_d, ulong param_m) {
if (!HasGCSession) {
throw new ClientException(EClientExceptionType.Failed, "CS2 Client is not connected to GC");
throw new ClientException(EClientExceptionType.Failed, Strings.ClientNotConnectedToGC);
}

await GCSemaphore.WaitAsync().ConfigureAwait(false);
Expand All @@ -271,11 +272,11 @@ internal async Task<CMsgGCCStrike15_v2_Client2GCEconPreviewDataBlockResponse> In
VerifyFunc = response => response.Body.iteminfo.itemid == param_a
};

Bot.ArchiLogger.LogGenericDebug(String.Format("Inspecting item: s {0} a {1} d {2} m {3}", param_s, param_a, param_d, param_m));
Bot.ArchiLogger.LogGenericDebug(String.Format("{0}: s {1} a {2} d {3} m {4}", Strings.InspectingItem, param_s, param_a, param_d, param_m));

var response = fetcher.Fetch(this, msg);
if (response == null) {
throw new ClientException(EClientExceptionType.Timeout, "Request timed out");
throw new ClientException(EClientExceptionType.Timeout, Strings.RequestTimeout);
}

return response.Body;
Expand All @@ -286,12 +287,12 @@ internal async Task<CMsgGCCStrike15_v2_Client2GCEconPreviewDataBlockResponse> In

internal async Task<CMsgGCCStrike15_v2_PlayersProfile> RequestPlayerProfile(ulong steam_id) { //uint account_id) {
if (!HasGCSession) {
throw new ClientException(EClientExceptionType.Failed, "CS2 Client is not connected");
throw new ClientException(EClientExceptionType.Failed, Strings.ClientNotConnectedToGC);
}

SteamID SteamID = new(steam_id);
if (!SteamID.IsValid || SteamID.AccountUniverse != EUniverse.Public || SteamID.AccountType != EAccountType.Individual || SteamID.AccountInstance != SteamID.DesktopInstance) {
throw new ClientException(EClientExceptionType.BadRequest, "Invalid Steam ID");
throw new ClientException(EClientExceptionType.BadRequest, Strings.InvalidSteamID);
}

await GCSemaphore.WaitAsync().ConfigureAwait(false);
Expand All @@ -308,11 +309,11 @@ internal async Task<CMsgGCCStrike15_v2_PlayersProfile> RequestPlayerProfile(ulon
VerifyFunc = response => response.Body.account_profiles.FirstOrDefault()?.account_id == account_id
};

Bot.ArchiLogger.LogGenericDebug(String.Format("Getting CS2 player profile: {0}", steam_id));
Bot.ArchiLogger.LogGenericDebug(String.Format("{0}: {1}", Strings.InspectingPlayer, steam_id));

var response = fetcher.Fetch(this, msg);
if (response == null) {
throw new ClientException(EClientExceptionType.Timeout, "Request timed out");
throw new ClientException(EClientExceptionType.Timeout, Strings.RequestTimeout);
}

return response.Body;
Expand All @@ -323,21 +324,21 @@ internal async Task<CMsgGCCStrike15_v2_PlayersProfile> RequestPlayerProfile(ulon

internal async Task<List<InventoryItem>> GetCasketContents(ulong casket_id) {
if (!HasGCSession) {
throw new ClientException(EClientExceptionType.Failed, "CS2 Client is not connected to GC");
throw new ClientException(EClientExceptionType.Failed, Strings.ClientNotConnectedToGC);
}

if (Inventory == null) {
throw new ClientException(EClientExceptionType.Failed, "Inventory not loaded yet");
throw new ClientException(EClientExceptionType.Failed, Strings.InventoryNotLoaded);
}

InventoryItem? casket = Inventory.Values.FirstOrDefault(x => x.ItemInfo.id == casket_id);
if (casket == null) {
throw new ClientException(EClientExceptionType.BadRequest, "Storage unit not found in inventory");
throw new ClientException(EClientExceptionType.BadRequest, Strings.CasketNotFound);
}

uint? items_count = casket.GetAttribute("items count")?.ToUInt32();
if (items_count == null) {
throw new ClientException(EClientExceptionType.Failed, "Could not determine storage unit item count");
throw new ClientException(EClientExceptionType.Failed, Strings.CasketContentsUndefined);
}

if (items_count == 0) {
Expand All @@ -362,21 +363,21 @@ internal async Task<List<InventoryItem>> GetCasketContents(ulong casket_id) {
VerifyFunc = response => response.Body.item_id.FirstOrDefault() == casket_id && response.Body.request == (uint) EGCItemCustomizationNotification.k_EGCItemCustomizationNotification_CasketContents
};

Bot.ArchiLogger.LogGenericDebug(String.Format("Opening casket {0}", casket_id));
Bot.ArchiLogger.LogGenericDebug(String.Format(Strings.OpeningCasket, casket_id));

if (fetcher.Fetch(this, msg) == null) {
throw new ClientException(EClientExceptionType.Timeout, "Request timed out");
throw new ClientException(EClientExceptionType.Timeout, Strings.RequestTimeout);
}

// Casket contents can sometimes continue to come in after we've recieved the k_EMsgGCItemCustomizationNotification response
DateTime waitTime = DateTime.Now.AddSeconds(30);
while (Inventory.Values.Where(x => x.CasketID == casket_id).Count() != items_count && DateTime.Now < waitTime) {
Bot.ArchiLogger.LogGenericDebug(String.Format("Waiting for casket {0} items", casket_id));
Bot.ArchiLogger.LogGenericDebug(String.Format(Strings.CasketContentsLoading, casket_id));
await Task.Delay(TimeSpan.FromSeconds(1)).ConfigureAwait(false);
}

if (Inventory.Values.Where(x => x.CasketID == casket_id).Count() != items_count) {
throw new ClientException(EClientExceptionType.Failed, String.Format("Casket item count mismatch, casket should have {0} items but only found {1}", items_count, Inventory.Values.Where(x => x.CasketID == casket_id).Count()));
throw new ClientException(EClientExceptionType.Failed, String.Format(Strings.CasketItemCountMismatch, items_count, Inventory.Values.Where(x => x.CasketID == casket_id).Count()));
}

return Inventory.Values.Where(x => x.CasketID == casket_id).ToList();
Expand All @@ -387,27 +388,27 @@ internal async Task<List<InventoryItem>> GetCasketContents(ulong casket_id) {

internal async Task<bool> AddItemToCasket(ulong casket_id, ulong item_id) {
if (!HasGCSession) {
throw new ClientException(EClientExceptionType.Failed, "CS2 Client is not connected to GC");
throw new ClientException(EClientExceptionType.Failed, Strings.ClientNotConnectedToGC);
}

if (Inventory == null) {
throw new ClientException(EClientExceptionType.Failed, "Inventory not loaded yet");
throw new ClientException(EClientExceptionType.Failed, Strings.InventoryNotLoaded);
}

if (Inventory.Values.FirstOrDefault(x => x.ItemInfo.id == item_id) == null) {
throw new ClientException(EClientExceptionType.BadRequest, "Item not found in inventory");
throw new ClientException(EClientExceptionType.BadRequest, Strings.InventoryItemNotFound);
}

InventoryItem? casket = Inventory.Values.FirstOrDefault(x => x.ItemInfo.id == casket_id);
if (casket == null) {
throw new ClientException(EClientExceptionType.BadRequest, "Storage unit not found in inventory");
throw new ClientException(EClientExceptionType.BadRequest, Strings.CasketNotFound);
}

uint? items_count = casket.GetAttribute("items count")?.ToUInt32();
if (items_count == null) {
throw new ClientException(EClientExceptionType.Failed, "Could not determine storage unit item count");
throw new ClientException(EClientExceptionType.Failed, Strings.CasketContentsUndefined);
} else if (items_count == 1000) {
throw new ClientException(EClientExceptionType.BadRequest, "Storage unit is full");
throw new ClientException(EClientExceptionType.BadRequest, Strings.CasketFull);
}

await GCSemaphore.WaitAsync().ConfigureAwait(false);
Expand Down Expand Up @@ -437,10 +438,10 @@ internal async Task<bool> AddItemToCasket(ulong casket_id, ulong item_id) {
}
};

Bot.ArchiLogger.LogGenericDebug(String.Format("Adding item {0} to casket {1}", item_id, casket_id));
Bot.ArchiLogger.LogGenericDebug(String.Format(Strings.AddingItemToCasket, item_id, casket_id));

if (fetcher.Fetch(this, msg) == null) {
throw new ClientException(EClientExceptionType.Timeout, "Request timed out");
throw new ClientException(EClientExceptionType.Timeout, Strings.RequestTimeout);
}

return true;
Expand All @@ -451,16 +452,16 @@ internal async Task<bool> AddItemToCasket(ulong casket_id, ulong item_id) {

internal async Task<bool> RemoveItemFromCasket(ulong casket_id, ulong item_id) {
if (!HasGCSession) {
throw new ClientException(EClientExceptionType.Failed, "CS2 Client is not connected to GC");
throw new ClientException(EClientExceptionType.Failed, Strings.ClientNotConnectedToGC);
}

if (Inventory == null) {
throw new ClientException(EClientExceptionType.Failed, "Inventory not loaded yet");
throw new ClientException(EClientExceptionType.Failed, Strings.InventoryNotLoaded);
}

InventoryItem? casket = Inventory.Values.FirstOrDefault(x => x.ItemInfo.id == casket_id);
if (casket == null) {
throw new ClientException(EClientExceptionType.BadRequest, "Storage unit not found in inventory");
throw new ClientException(EClientExceptionType.BadRequest, Strings.CasketNotFound);
}

// Does not verify that the item is actually in the crate, to do that we would need to request the crate contents first
Expand Down Expand Up @@ -492,10 +493,10 @@ internal async Task<bool> RemoveItemFromCasket(ulong casket_id, ulong item_id) {
}
};

Bot.ArchiLogger.LogGenericDebug(String.Format("Removing item {0} from casket {1}", item_id, casket_id));
Bot.ArchiLogger.LogGenericDebug(String.Format(Strings.RemovingItemFromCasket, item_id, casket_id));

if (fetcher.Fetch(this, msg) == null) {
throw new ClientException(EClientExceptionType.Timeout, "Request timed out");
throw new ClientException(EClientExceptionType.Timeout, Strings.RequestTimeout);
}

return true;
Expand Down
5 changes: 3 additions & 2 deletions CS2Interface/CS/GameData.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.Threading;
using System.Threading.Tasks;
using ArchiSteamFarm.Core;
using CS2Interface.Localization;

namespace CS2Interface {
internal static class GameData {
Expand All @@ -21,7 +22,7 @@ internal static void Update(bool forceUpdate = false) {
ItemsGameCdn.Updated = false;
CsgoEnglish.Updated = false;
DoNotUpdateUntil = DateTime.Now.AddMinutes(15);
ASF.ArchiLogger.LogGenericInfo("Refreshing CS2 game data");
ASF.ArchiLogger.LogGenericInfo(Strings.GameDataRefreshing);
}

if (!ItemsGame.Updated || !ItemsGameCdn.Updated || !CsgoEnglish.Updated) {
Expand Down Expand Up @@ -72,7 +73,7 @@ private static async Task DoUpdate() {
if (ItemsGame.Updated && ItemsGameCdn.Updated && CsgoEnglish.Updated) {
UpdateTimer.Change(Timeout.Infinite, Timeout.Infinite);
IsUpdating = false;
ASF.ArchiLogger.LogGenericInfo("CS2 game data loaded");
ASF.ArchiLogger.LogGenericInfo(Strings.GameDataLoadingSuccess);
}
} catch (Exception e) {
ASF.ArchiLogger.LogGenericException(e);
Expand Down
13 changes: 13 additions & 0 deletions CS2Interface/CS2Interface.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<LangVersion>latest</LangVersion>
<TargetFramework>net8.0</TargetFramework>
<Deterministic>true</Deterministic>
<CoreCompileDependsOn>PrepareResources;$(CompileDependsOn)</CoreCompileDependsOn>
</PropertyGroup>

<ItemGroup>
Expand All @@ -17,4 +18,16 @@
<ProjectReference Include="..\ArchiSteamFarm\ArchiSteamFarm\ArchiSteamFarm.csproj" />
</ItemGroup>

<!-- https://www.paraesthesia.com/archive/2022/09/30/strongly-typed-resources-with-net-core/ -->
<ItemGroup>
<EmbeddedResource Update="Localization\Strings.resx">
<Generator>MSBuild:Compile</Generator>
<LastGenOutput>Strings.Designer.cs</LastGenOutput>
<StronglyTypedFileName>$(IntermediateOutputPath)\Strings.Designer.cs</StronglyTypedFileName>
<StronglyTypedLanguage>CSharp</StronglyTypedLanguage>
<StronglyTypedNamespace>CS2Interface.Localization</StronglyTypedNamespace>
<StronglyTypedClassName>Strings</StronglyTypedClassName>
</EmbeddedResource>
</ItemGroup>

</Project>
13 changes: 6 additions & 7 deletions CS2Interface/Commands.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System.ComponentModel;
using ArchiSteamFarm.Core;
using System.Collections.Generic;
using ArchiSteamFarm.Localization;
using System.Linq;

namespace CS2Interface {
Expand Down Expand Up @@ -61,7 +60,7 @@ internal static class Commands {
}

if (!bot.IsConnectedAndLoggedOn) {
return FormatBotResponse(bot, Strings.BotNotConnected);
return FormatBotResponse(bot, ArchiSteamFarm.Localization.Strings.BotNotConnected);
}

(_, string message) = await ClientHandler.ClientHandlers[bot.BotName].Run().ConfigureAwait(false);
Expand All @@ -77,7 +76,7 @@ internal static class Commands {
HashSet<Bot>? bots = Bot.GetBots(botNames);

if ((bots == null) || (bots.Count == 0)) {
return access >= EAccess.Owner ? FormatStaticResponse(String.Format(Strings.BotNotFound, botNames)) : null;
return access >= EAccess.Owner ? FormatStaticResponse(String.Format(ArchiSteamFarm.Localization.Strings.BotNotFound, botNames)) : null;
}

IList<string?> results = await Utilities.InParallel(bots.Select(bot => ResponseRun(bot, ArchiSteamFarm.Steam.Interaction.Commands.GetProxyAccess(bot, access, steamID)))).ConfigureAwait(false);
Expand All @@ -93,7 +92,7 @@ internal static class Commands {
}

if (!bot.IsConnectedAndLoggedOn) {
return FormatBotResponse(bot, Strings.BotNotConnected);
return FormatBotResponse(bot, ArchiSteamFarm.Localization.Strings.BotNotConnected);
}

string message = ClientHandler.ClientHandlers[bot.BotName].Stop();
Expand All @@ -109,7 +108,7 @@ internal static class Commands {
HashSet<Bot>? bots = Bot.GetBots(botNames);

if ((bots == null) || (bots.Count == 0)) {
return access >= EAccess.Owner ? FormatStaticResponse(String.Format(Strings.BotNotFound, botNames)) : null;
return access >= EAccess.Owner ? FormatStaticResponse(String.Format(ArchiSteamFarm.Localization.Strings.BotNotFound, botNames)) : null;
}

IEnumerable<string?> results = bots.Select(bot => ResponseStop(bot, ArchiSteamFarm.Steam.Interaction.Commands.GetProxyAccess(bot, access, steamID)));
Expand All @@ -125,7 +124,7 @@ internal static class Commands {
}

if (!bot.IsConnectedAndLoggedOn) {
return FormatBotResponse(bot, Strings.BotNotConnected);
return FormatBotResponse(bot, ArchiSteamFarm.Localization.Strings.BotNotConnected);
}

(_, string message) = ClientHandler.ClientHandlers[bot.BotName].Status();
Expand All @@ -141,7 +140,7 @@ internal static class Commands {
HashSet<Bot>? bots = Bot.GetBots(botNames);

if ((bots == null) || (bots.Count == 0)) {
return access >= EAccess.Owner ? FormatStaticResponse(String.Format(Strings.BotNotFound, botNames)) : null;
return access >= EAccess.Owner ? FormatStaticResponse(String.Format(ArchiSteamFarm.Localization.Strings.BotNotFound, botNames)) : null;
}

IEnumerable<string?> results = bots.Select(bot => ResponseStatus(bot, ArchiSteamFarm.Steam.Interaction.Commands.GetProxyAccess(bot, access, steamID)));
Expand Down
Loading

0 comments on commit ccd056b

Please sign in to comment.