-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InternalServerError ➡️ Status: Fail/InvalidPackage ➡️ Status: Fail/RateLimited #11
Comments
This is just the plugin not being aggressive enough with how it filters out invalid packages. Presumably yes, these will all become redeemable free packages eventually, but it's hard to say when. By the looks of them, the subs are all valid and none of the properties on them would have to change for them to be redeemable. It's just the the apps that they grant aren't released yet, and so it's the apps that can't be redeemed. I should be able to filter these out without the risk of missing packages. The subs may not change, but the apps will have to, and so the plugin will have a chance to rediscover them in the future. |
Thank you for your reply!
|
This new version should get rid of almost all of the invalid package errors, you can test it here: FreePackages V1.2.0.zip As for the rate limiting, I'm not sure what you mean by "too fast". You should usually get rate limited after 50 package activations whether or not they were successful. Some errors don't seem to actually count against the rate limit, but others do. The plugin currently doesn't take this into consideration. The error you're showing though isn't the plugin just thinking it's rate limited, you actually did get rate limited. I've also noticed that if you don't wait a full hour after getting a rate limit error, Steam will sometimes let you activate a few packages (less than 50) before it rate limits you again. I would only expect something like that to happen if you were also activating packages from outside of the plugin. If the plugin ever sees a rate limited error, it pauses for 1 hour starting from the time it got the error. |
Thank you, I will try this new version of the plugin! About the rate-limit, I was under the impression that
I suspect it is probably the latter explanation. |
It is worth testing to see how certain errors effect the limit. I'm almost certain they are treated differently, but I'm not sure of the details. Normally when ASF gets an error it will retry 5 times, but it's not the case here, all requests are only made once. |
Thank you for the precision! I close the issue for now and will reopen it if I encounter again many invalid packages! |
I get these warnings with the new version. I will try again tomorrow to see if the issue persists.
|
I think that might be a Steam or an ASF issue. I saw that happen earlier, but only on 1 of my accounts. I wasn't using that version of the plugin at the time. |
Yes, a new ASF issue: |
On my main account, which has everything but demos (cf. the note below), I have very few packages to try to add. However, I have noticed that I get rate-limited quite fast after getting many times the
Fail/InvalidPackage
status due toInternalServerError
.I don't know if something can be done about this, as I reach the rate-limit (50) very fast. Originally, there were 20 or so packages to try, plus a few which were discovered, and the rate-limit status was ideal at 0/50.
When I check some of the invalid packages, I can notice that the included app is unknown (both
App Type
andName
).For instance: https://steamdb.info/sub/947765/apps/
So I wonder i) if this is normal, ii) if this is because the software is too fast and the free packages would become valid in an hour or so, iii) if something can be done to prevent triggering the rate-limit if the app is of unknown type or unknown name.
The text was updated successfully, but these errors were encountered: