-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] MinReviewScore Delay #30
Comments
For this specific scenario, I suggest to remove your filters (including
|
Ah, I didn't realize that it was so few games/applications. I also kinda figured some delay thing would have been a decent architectural change/overkill and might not have been worth it anyway. I'll just remove the |
True, a delay would have been quite the hassle to implement. While I agree that just not using
You could then change the original config to only ignore the review score on "FreePackagesFilters": [
{
"Types": [
"DLC"
]
},
{
"Types": [
"Game"
],
"Languages": [
"english"
],
"MinReviewScore": 6,
"IgnoreFreeWeekends": true,
"NoCostOnly": true
},
{
"Types": [
"Game"
],
"Languages": [
"english"
],
"MinDaysOld": 1,
"IgnoreFreeWeekends": true,
"NoCostOnly": true
}
] If you'd like to test this feature you can download the latest build here: FreePackages V1.5.0.0 |
Sorry I took a month to reply to this... but thank you for this new |
Hello! I noticed that the game Content Warning came out today, along with a No Cost promotional package available for 24 hours. I assumed that FreePackages would pick this up, but it didn't. These are my settings:
The only part of the config that might be ignoring the game would be the
MinReviewScore
, as at the time of processing, my guess is that there were zero reviews.My feature request is for there to be some sort of cache that holds onto free packages that don't have the required review score but otherwise match on all the other settings, so that perhaps in a couple of hours it'll have the target review score and can be added. In this case, it's at about 91%, so well over the threshold for this config. However, since it was checked right when it was made available with no reviews, it won't be added (unless another package change happens between now and the 24 hours later when it becomes not free).
Also, I am assuming that this is the reason it wasn't added. If I missed something or configured something wrong please let me know. My guess is that if this was a highly-rated existing game that went on sale for 24 hours it would have been picked up just fine. But it's this edge case where a brand new game doesn't have enough reviews to get picked up.
The text was updated successfully, but these errors were encountered: