Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9507: Replace unit contact card title with a radio button selection #1142

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Dec 19, 2024

UHF-9507

What was done

  • Refactor the unit contact card logic on hdbt
  • Replace the title display logic with the heading radiobutton selection

How to install

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@teroelonen teroelonen changed the title UHF-9507: Replace unit contact card title with a radiobutton selection UHF-9507: Replace unit contact card title with a radio button selection Dec 19, 2024
@teroelonen teroelonen marked this pull request as ready for review December 20, 2024 17:27
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1142/html_report/

Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants