UHF-10773: Helsinki near you - Services block #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jeremysteerio
force-pushed
the
UHF-10773
branch
from
5353b6f to
d1b823a
Compare
juho-lehmonen
suggested changes
Dec 17, 2024
| * The request. | ||
| * | ||
| * @return array | ||
| * A renderable array. | ||
| */ | ||
| public function content(Request $request) : array|RedirectResponse { | ||
| $address = $request->query->get('q'); | ||
| $address = Xss::filter($request->query->get('q')); |
There was a problem hiding this comment.
This causes a deprecated function warning if the query parameter is left empty. Should we check if this is NULL or empty before running it through the filter?
|
juho-lehmonen
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-10773
What was done
How to install
git checkout UHF-10773composer require drupal/hdbt:dev-UHF-10773make freshmake drush-crHow to test
Sketch: https://www.figma.com/design/udh2zu4J95VYDIzT7DtbXW/Alueellisuus?node-id=4161-11902&t=v6YlVbP2sDsyihz1-4
Continuous documentation
Translations
Other PRs