Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8650 Config ignore fix #837

Merged
merged 3 commits into from
Oct 31, 2024
Merged

UHF-8650 Config ignore fix #837

merged 3 commits into from
Oct 31, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Oct 31, 2024

UHF-8650

What was done

  • Added uninstall hook to remove the module settings file when module is uninstalled.
  • Switched the deprecated config_ignore_settings_alter to config_ignore_ignored_alter. Ignored only the config objects in the hdbt_cookie_banner.settings.yml. Otherwise uninstallation or revert would not work.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8650_config_ignore_fix
  • Run make shell

How to test

  • Run drush en -y hdbt_cookie_banner and drush cex -y
  • Check that the cookie_banner.settings.yml is exported to conf/cmi
  • Check that code follows our standards

…fig_ignore_ignored_alter. Ignored only the config objects in the hdbt_cookie_banner.settings.yml. Otherwise uninstallation or revert would not work.
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants