Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X Fix recursion when importing configuraition. #868

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Dec 13, 2024

What was done

  • Fixed recursion when importing translations.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_config_import_recursion
  • Run make drush-updb drush-cr

How to test

  • In helfi etusivu, run drush sql-drop -y && drush si -y && drush cr && drush si --existing-config -y && drush cim -y and check that this line is not repeated for hundreds of times.
    • Deleted and replaced configuration entity "field.field.paragraph.event_list.field_filter_keywords"
  • Check that code follows our standards

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.87%. Comparing base (f096789) to head (e8afa23).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #868   +/-   ##
=========================================
  Coverage     17.87%   17.87%           
  Complexity      285      285           
=========================================
  Files            36       36           
  Lines          1080     1080           
=========================================
  Hits            193      193           
  Misses          887      887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants