Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11017: Visual regression tests for Image Gallery paragraph #883

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 9, 2025

UHF-11017

What was done

  • Added test content for the visual regression tests on image gallery.

How to install

  • Test this out on a clean install so create that instance based on the helfi_platform: composer create-project City-of-Helsinki/drupal-helfi-platform:dev-main testpage --no-interaction --repository https://repository.drupal.hel.ninja/
  • composer reinstall drupal/helfi_platform_config --prefer-source
  • composer reinstall drupal/hdbt --prefer-source
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-11017
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-11017
  • Once the site is created go to the directory and run make new.
  • When the site is installed run drush en -y helfi_test_content to enable testing content.

How to test

  • Login to the site and make sure that from the menu you can find DC: Image Gallery under DC: Components menu item. It should have multiple variants of image gallery paragraph.
  • Now run the full visual regression tests. Start by installing required node modules by running npm i under the hdbt-theme folder.
  • After that is complete npm run full-reference to get the reference images. This might take a while.
  • After the reference is complete run npm run build once more just to be safe.
  • The run the full test suite npm run full-test.
  • Make sure the tests pass and that the different variants of image gallery are tested.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.77%. Comparing base (983a87e) to head (b4fa6e2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #883   +/-   ##
=========================================
  Coverage     17.77%   17.77%           
  Complexity      285      285           
=========================================
  Files            36       36           
  Lines          1080     1080           
=========================================
  Hits            192      192           
  Misses          888      888           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants