-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-11017: Visual regression tests for Image Gallery paragraph #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Merged
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
=========================================
Coverage 17.77% 17.77%
Complexity 285 285
=========================================
Files 36 36
Lines 1080 1080
=========================================
Hits 192 192
Misses 888 888 ☔ View full report in Codecov by Sentry. |
|
khalima
approved these changes
Jan 10, 2025
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-11017
What was done
How to install
composer create-project City-of-Helsinki/drupal-helfi-platform:dev-main testpage --no-interaction --repository https://repository.drupal.hel.ninja/
composer reinstall drupal/helfi_platform_config --prefer-source
composer reinstall drupal/hdbt --prefer-source
composer require drupal/helfi_platform_config:dev-UHF-11017
composer require drupal/hdbt:dev-UHF-11017
make new
.drush en -y helfi_test_content
to enable testing content.How to test
npm i
under the hdbt-theme folder.npm run full-reference
to get the reference images. This might take a while.npm run build
once more just to be safe.npm run full-test
.Continuous documentation
Other PRs