UHF-10406: Catch exceptions from UrlResolverInterface::getProviderByUrl #884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-10406
What was done
Fix crashes with some YouTube link.
Sentry issue: https://sentry.hel.fi/organizations/city-of-helsinki/issues/46100/?query=is%3Aunresolved+OEmbed&referrer=issue-stream&statsPeriod=14d
This issue was hard to reproduce locally. I believe the root cause was that google blocks OpenShift environment:
Some YouTube links, like
https://youtube.com/watch?v=g2eYKMjE8ew
(missing www.), are perfecly fine, but not included in the list provider by drupal/oembed_providers: https://oembed.com/providers.json. This causes these links to make network requests to google from the backend whenever they are used. According to the Sentry logs, Google seems to be banning our production environment.These PRs include two fixes to this issue:
How to install
git pull origin UHF-10406
make fresh
composer require drupal/helfi_platform_config:dev-UHF-10406
composer require drupal/hdbt:dev-UHF-10406
make drush-updb drush-cr
How to test
throw new ResourceException('Test.', $url);
to the top ofUrlResolver::getProviderByUrl
. View some pages that have video embeds. They should not be shown at all (unless cached).drush migrate:import helfi_rekry_jobs --reset-threshold 1 --update
. The video should be removed.Continuous documentation
Translations
Other PRs