Remove unique constraint from land use agreement estate ids #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #188 +/- ##
===========================================
+ Coverage 71.72% 71.74% +0.01%
===========================================
Files 261 262 +1
Lines 16234 16244 +10
Branches 1681 1681
===========================================
+ Hits 11644 11654 +10
Misses 4367 4367
Partials 223 223
Continue to review full report at Codecov.
|
tomijarvi
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the uniqueness constraint from land use agreement
estate_id.Updating unique fields in nested serializers has long been a source of trouble and/or discussion in DRF, and as I don't really see the need for it here, I opted to remove it instead of writing a workaround.