Lock Javascript dependencies #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a good practice to lock dependency versions. But there's a specific reason why this needs to be done now. Tunnistamo isn't compatible with bootstrap-sass version 3.4.2. That version switches [1] to a newish Sass syntax that isn't backwards compatible [2]. Tunnistamo uses the django-sass-processor package to do Sass preprocessing. That package uses the libsass library, which is deprecated and will never support any newer Sass syntax [3]. As a result, Tunnistamo is stuck with an old Sass syntax version unless the preprocessor system is changed to something more modern. In this commit the bootstrap-sass is locked to version 3.4.1 which still uses the older syntax that libsass supports. [1] twbs/bootstrap-sass#1221 [2] https://sass-lang.com/documentation/breaking-changes/slash-div [3] https://sass-lang.com/blog/libsass-is-deprecated
Codecov Report
@@ Coverage Diff @@
## develop #221 +/- ##
========================================
Coverage 78.07% 78.07%
========================================
Files 88 88
Lines 3680 3680
========================================
Hits 2873 2873
Misses 807 807 Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
mikkokeskinen
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a good practice to lock dependency versions. But there's a specific reason why this needs to be done now.
Tunnistamo isn't compatible with bootstrap-sass version 3.4.2. That version switches [1] to a newish Sass syntax that isn't backwards compatible [2]. Tunnistamo uses the django-sass-processor package to do Sass preprocessing. That package uses the libsass library, which is deprecated and will never support any newer Sass syntax [3]. As a result, Tunnistamo is stuck with an old Sass syntax version unless the preprocessor system is changed to something more modern.
In this commit the bootstrap-sass is locked to version 3.4.1 which still uses the older syntax that libsass supports.
[1] twbs/bootstrap-sass#1221
[2] https://sass-lang.com/documentation/breaking-changes/slash-div
[3] https://sass-lang.com/blog/libsass-is-deprecated