HL-836 | Fix pdf viewer issues #2115
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2115 +/- ##
===========================================
- Coverage 33.07% 33.07% -0.01%
===========================================
Files 773 773
Lines 15052 15055 +3
Branches 3199 3199
===========================================
Hits 4979 4979
- Misses 9582 9585 +3
Partials 491 491
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
te-admn is deployed to: https://te-admn-2115.test.kuva.hel.ninja 🚀🚀🚀 |
|
te-yout is deployed to: https://te-yout-2115.test.kuva.hel.ninja 🚀🚀🚀 |
|
te-bknd is deployed to: https://te-bknd-2115.test.kuva.hel.ninja 🚀🚀🚀 |
|
Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2115.test.kuva.hel.ninja 🚀🚀🚀 |
|
Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2115.test.kuva.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://te-yout-2115.test.kuva.hel.ninja! 😆🎉🎉🎉 |
TestCafe result is success for https://te-admn-2115.test.kuva.hel.ninja! 😆🎉🎉🎉 |
|
Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2115.test.kuva.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkibenefit-bf-appl-2115.test.kuva.hel.ninja! 😆🎉🎉🎉 |
|
ks-empl is deployed to: https://ks-empl-2115.test.kuva.hel.ninja 🚀🚀🚀 |
|
ks-hdlr is deployed to: https://ks-hdlr-2115.test.kuva.hel.ninja 🚀🚀🚀 |
|
ks-bknd is deployed to: https://ks-bknd-2115.test.kuva.hel.ninja 🚀🚀🚀 |
|
ks-youth is deployed to: https://ks-youth-2115.test.kuva.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://ks-handler-2115.test.kuva.hel.ninja! 😆🎉🎉🎉 |
TestCafe result is failure for https://ks-empl-2115.test.kuva.hel.ninja! 😿💢💥💥 |
There was a problem hiding this comment.
Don't really like the idea of keeping deps in repo. This should be eventually fixed properly, but should we for now consider this as a temporary fix? What @rikuke thinks?
Some info here wojtekmaj/react-pdf#97
TestCafe result is failure for https://ks-youth-2115.test.kuva.hel.ninja! 😿💢💥💥 |
I can try to get this working today but no guarantees. Webpack configuration is not my forte and it should be done in applicant's |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sirtawast
force-pushed
the
HL-836
branch
3 times, most recently
from
66fdc82 to
d1cf8d4
Compare
|
[yjdh-kesaseteli-shared] Kudos, SonarCloud Quality Gate passed!
|
|
[yjdh-kesaseteli-handler] Kudos, SonarCloud Quality Gate passed! |
|
[yjdh-kesaseteli-api] Kudos, SonarCloud Quality Gate passed! |
|
[yjdh-kesaseteli-employer] Kudos, SonarCloud Quality Gate passed! |
|
[yjdh-kesaseteli-youth] Kudos, SonarCloud Quality Gate passed! |
Description ✨
Issues
Loading the worker frompublic/is not elegant and webpack should probably load it but webpack is keen on generating the file with hash included in the name for cache busting purposes. That won't allow the resource to be loaded from a single static path so we need to revisit that after NextJs12 upgrade, which has changes in the asset pipeline.UPDATE: Loads from webpack now, with considerably smaller JS footprint ~500KB.