Fixed autobind for async/await in react components #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuggins
force-pushed
the
bug/autobind-async-await
branch
from
20fce8d to
3a2d263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
N/A
What problem does this PR solve?
This fixes issues with trying to use the
async/awaitkeywords in react component functions, which was not supported in react-hot-loader v3. (More details can be found here.) It also updates the new blacklist check to useasyncinstead ofpromise.then.How did you solve this problem?
I upgraded react-hot-loader to v4 and updated a react component function to use
async.react-hot-loaderupdates are based upon the documentation found here.How did you make sure your solution works?
I smoke tested sending NEO to AasqbuVKaCARqoWfp64ygM5fxYBqmMMgpq, which can be found on the blacklist.
Are there any special changes in the code that we should be aware of?
N/A
Is there anything else we should know?
N/A