Count unexpected successes as failures as unittest does. Resolves #241

CleanCut · Apr 26, 2021 · 2b0e128 · 2b0e128
1 parent 01405d6
commit 2b0e128
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/green/result.py b/green/result.py
@@ -544,7 +544,7 @@ def stopTestRun(self):
             self.stream.writeln(self.colors.failing("No Tests Found"))
         else:
             grade = self.colors.passing("OK")
-            if self.errors or self.failures:
+            if not self.wasSuccessful():
                 grade = self.colors.failing("FAILED")
             self.stream.writeln("{} ({})".format(grade, ", ".join(stats)))
 
@@ -791,4 +791,4 @@ def wasSuccessful(self):
         ):
             return False
         else:
-            return len(self.all_errors) == 0
+            return len(self.all_errors) + len(self.unexpectedSuccesses) == 0
diff --git a/green/test/test_result.py b/green/test/test_result.py
@@ -1056,7 +1056,7 @@ def test_wasSuccessful_unexpectedSuccesses(self):
         self.args.verbose = 1
         gtr = GreenTestResult(self.args, GreenStream(self.stream))
         gtr.unexpectedSuccesses.append("anything")
-        self.assertEqual(gtr.wasSuccessful(), True)
+        self.assertEqual(gtr.wasSuccessful(), False)
 
     def test_wasSuccessful_coverageFails(self):
         """