Skip to content

Commit

Permalink
#235 junit_report does not work in setup.cfg (#236)
Browse files Browse the repository at this point in the history
* #235 junit_report does not work in setup.cfg

fix junit_report now gets read as string instead of boolean

* Fix lint. Fix default.

Co-authored-by: Jannik Waschkau <[email protected]>
Co-authored-by: Nathan Stocks <[email protected]>
  • Loading branch information
3 people authored Nov 2, 2020
1 parent 96409be commit 3334232
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions green/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
config=None, # Not in configs
file_pattern="test*.py",
test_pattern="*",
junit_report=False,
junit_report="",
run_coverage=False,
cov_config_file=True, # A string with a special boolean default
quiet_coverage=False,
Expand Down Expand Up @@ -684,7 +684,6 @@ def mergeConfig(args, testing=False): # pragma: no cover
"no_tracebacks",
"disable_windows",
"quiet_coverage",
"junit_report",
]:
config_getter = config.getboolean
elif name in ["processes", "debug", "verbose", "minimum_coverage"]:
Expand All @@ -698,6 +697,7 @@ def mergeConfig(args, testing=False): # pragma: no cover
"omit_patterns",
"warnings",
"test_pattern",
"junit_report",
]:
config_getter = config.get
elif name in ["targets", "help", "config"]:
Expand Down

0 comments on commit 3334232

Please sign in to comment.